Subversion Repositories oidplus

Rev

Rev 1187 | Rev 1206 | Go to most recent revision | Show entire file | Regard whitespace | Details | Blame | Last modification | View Log | RSS feed

Rev 1187 Rev 1201
Line 1... Line 1...
1 
 
 1 
 
2 
April 2023 planned:
 2 
April 2023 planned:
3 
- Don't send information object OIDs to oid-info.com anymore
 3 
- Don't send "information object (i.e. Non-OIDs)" OIDs to oid-info.com anymore
4 
- In re Internet access:
 4 
- In re Internet access:
5 
    * Check if all instances of https://github.com/danielmarschall/oidplus/issues/5 ("Offline mode") have been addressed
 5 
    * Check if all instances of https://github.com/danielmarschall/oidplus/issues/5 ("Offline mode") have been addressed
6 
    * Everywhere where url_post_contents() is used, we need to check url_post_contents_available() too.
 6 
    * Everywhere where url_post_contents() is used, we need to check url_post_contents_available() too.
7 
    * Everywhere where url_get_contents() is used, we need to check url_get_contents_available() too.
 7 
    * Everywhere where url_get_contents() is used, we need to check url_get_contents_available() too.
8 
 
 8 
 
- 
 
 9 
Exception Refactoring:
- 
 
 10 
- [DONE]  Instead of catching OIDplusException, catch Exception
- 
 
 11 
- [DONE]  Check every "new OIDplusException" and "new \OIDplusException" if it contains HTML and needs to be "new OIDplusHtmlException"
- 
 
 12 
- [DONE]  Check every instance of "->getMessage()" it it needs to be HTML or Text
- 
 
 13 
                HTML would be   $htmlmsg = $e instanceof OIDplusException ? $e->getHtmlMessage() : htmlentities($e->getMessage());
- 
 
 14 
-         Check every instance of "catch (\Exception"
- 
 
 15 
                Question: In the whole code we write "catch (\Exception" . Is that correct or should we write "catch (\Throwable" ?
- 
 
 16 
-         Why are there 66 matches of  "$out['icon'] = 'img/error.png';"  ?  Shouldn't gui() just throw OIDplusException or OIDplusHtmlException and let the caller do the rest?
- 
 
 17 
                Problem is this: If gui() uses $out[...], then the title can be chosen
- 
 
 18 
                But we still should prefer throwing Exceptions!
- 
 
 19 
-               Idea: Implement "friendly Exceptions"
- 
 
 20 
                    * A "friendly" Exception is an Exception where the user has done something wrong (i.e. they are not logged in).
- 
 
 21 
                    * The error is therefore clearly known and therefore a technical stacktrace is NOT shown.
- 
 
 22 
 
9 
Type safety:
 23 
Type safety:
10 
- PhpStorm warnings
 24 
- PhpStorm warnings
11 
- Re-Check "mixed"
 25 
- Re-Check "mixed"
12 
- Nullable params passed to non-nullable methods => find using PHPStan level 7
 26 
- Nullable params passed to non-nullable methods => find using PHPStan level 7
13 
 
 27