Rev 416 | Rev 423 | Go to most recent revision | Show entire file | Regard whitespace | Details | Blame | Last modification | View Log | RSS feed
| Rev 416 | Rev 419 | ||
|---|---|---|---|
| Line 24... | Line 24... | ||
| 24 | 24 | ||
| 25 | - Plugins created by the custom implementation of `UpdateResourceA` (for Win9x and WinNT<4.0) could not be loaded on |
25 | - Plugins created by the custom implementation of `UpdateResourceA` (for Win9x and WinNT<4.0) could not be loaded on |
| 26 | some versions of Windows, because the Optional PE Header `SizeOfImage` was calculated wrong. |
26 | some versions of Windows, because the Optional PE Header `SizeOfImage` was calculated wrong. |
| 27 | 27 | ||
| 28 | Fixed in SVN Revision 415. |
28 | Fixed in SVN Revision 415. |
| - | 29 | Reported bug in the Wine code here: https://bugs.winehq.org/show_bug.cgi?id=52119 |
|
| 29 | 30 | ||
| 30 | - The version info of a 64 bit plugin cannot be written using Windows NT 3.51, because the resources could not be loaded from the 64 bit image. |
31 | - The version info of a 64 bit plugin cannot be written using Windows NT 3.51, because the resources could not be loaded from the 64 bit image. |
| 31 | 32 | ||
| 32 | Fixed in SVN Revision 416: The version info template is now inserted into the 32 bit image as `TPLT` resource. |
33 | Fixed in SVN Revision 416: The version info template is now inserted into the 32 bit image as `TPLT` resource. |
| 33 | Therefore, the 64 bit image does not need to be read. |
34 | Therefore, the 64 bit image does not need to be read. |
| 34 | 35 | ||
| 35 | Open problems: |
36 | - `LoadImageA` not found in WinAPI of Windows NT 3.1 |
| 36 | -------------- |
- | |
| 37 | 37 | ||
| 38 | - WinNT311: "msctls_trackbar32" is not supported by Windows NT 3.1. DialogBoxParamA crashes with the confusing error code "Invalid Cursor Handle". |
38 | Fixed in SVN Revision 419: We removed the "+" and "-" zoom pictures and replaced them with buttons (including the zoom percentage label), |
| 39 | Note: msctls_trackbar32 seems to be defined in COMCTL32.DLL, but Win NT 3.1 has no REGSVR32.EXE, so there can't be any controls added?? |
39 | because this looks better in Windows 10, and buttons are more likely to be clicked intuitively. |
| 40 | For now, we added an error message if the class can't be found (SVN Revision 413). |
40 | The caution icon is now a subclass of "Button" instead of "STATIC", and the icon is drawn using `BS_OWNERDRAW` and `DrawIcon`. |
| 41 | Windows NT 3.51 has COMCTL32.DLL and works perfectly with the trackbars! |
41 | Note that Windows 3.51 does not support static controls to be clicked (probably `SS_NOTIFY` and `STM_CLICKED` is not |
| - | 42 | implemented). |
|
| 42 | 43 | ||
| 43 | - WinNT311: `LoadImageA` not found in WinAPI of Windows NT 3.1 (this is the last unresolved import!) ... how should we draw it? Filter Factory uses DrawIcon on a BUTTON control (BS_OWNERDRAW | WS_CHILD | WS_CLIPSIBLINGS). |
- | |
| 44 | Remove "Hand Question" cursor in order to use the "Static" class instead of the custom class "CautionIcon"? |
- | |
| 45 | Windows NT 3.51 has `LoadImageA` and works. |
44 | - Windows NT 3.51 clicking the zoom icons and caution icons does not work! |
| 46 | TODO: Make call dynamic, so that Windows NT 3.1 can show at least an error message instead of failing silently. |
- | |
| 47 | 45 | ||
| 48 | - If hand cursor is not existing in Windows, then use a handpointer located in the resources. |
46 | Fixed in SVN Revision 419: Windows 3.51 does not allow static controls to be clicked. |
| - | 47 | Therefore, the zoom icons and the caution icons are now Buttons classes (or subclasses). |
|
| 49 | 48 | ||
| 50 | - WinNT311: Icons (+, - and exclamation sign) graphics are broken (probably need low colored icons?) |
49 | Things couldn't solve yet: |
| - | 50 | -------------------------- |
|
| 51 | 51 | ||
| 52 | - Icons (+, - and exclamation sign) are drawn too big (Windows NT 3.1, and also Windows NT 3.51) |
52 | - WinNT311: "msctls_trackbar32" is not supported by Windows NT 3.1. DialogBoxParamA crashes with the confusing error code "Invalid Cursor Handle". |
| 53 | They are STATIC with SS_ICON. It is probably automatically 32x32 |
53 | Note: msctls_trackbar32 seems to be defined in COMCTL32.DLL, but Win NT 3.1 has no REGSVR32.EXE, so there can't be any controls added?? |
| 54 | - | ||
| 55 | - Windows NT 3.51 clicking the zoom icons does not work! |
54 | For now, we simply remove the sliders by subclassing them from a static control, and let the user enter the numbers via keyboard only (SVN Revision 419). |
| 56 | The click event probably only works for Button classes? |
55 | Windows NT 3.51 has COMCTL32.DLL and works perfectly with the trackbars! |
| 57 | => Ok, changed to pushbutton with ownerdraw. Now works |
- | |
| 58 | 56 | ||
| - | 57 | - Preview pane cannot be panned, because it seems that anything clickable needs to be a pushbutton in Win NT 3.51 |
|
| 59 | - Help button does not work |
58 | It also doesn't work if the control is `STATIC` |
| - | 59 | It looks like `SS_NOTIFY` and `STN_CLICKED` is not implemented in Win NT 3.5x |
|
| 60 | 60 | ||
| - | 61 | - WinNT351: Help button does not work |
|
| 61 | - WinNT311+351: Preview image is not drawn at dialog box opening. You need to enter something first. |
62 | => Maybe WinExec helps? But can we open an URL there? Unlikely... |
| 62 | 63 | ||
| 63 | - Preview pane cannot be panned, because it seems that anything clickable needs to be a pushbutton in Win NT 3.51 |
64 | - WinNT311+WinNT351: The preview image is not drawn at dialog box opening. You need to enter something first. |
| - | 65 | Nothing seems to work. Already tried doing a `recalc_preview` and `drawpreview` in `WM_SHOWWINDOW`, |
|
| - | 66 | or sending a message `SendMessage(hDlg, WM_USER + 123, 0, 0);` inside `WM_INITDIALOG`, but the code |
|
| 64 | TODO: implement area as pushbutton? |
67 | seems to be executed while the dialog is still hidden (you can see this by showing a messagebox). |
| 65 | 68 | ||
| 66 | Questions: |
69 | Open questions: |
| 67 | ---------- |
70 | --------------- |
| 68 | 71 | ||
| 69 | Which CPU architecture is required for OpenWatcom settings? Should we do very low settings 80386? |
72 | Which CPU architecture is required for OpenWatcom settings? Should/can we lower the CPU code generation settings in OpenWatcom (80386)? |