Subversion Repositories filter_foundry

Compare Revisions

Regard whitespace Rev 446 → Rev 447

/trunk/TODO.md
13,11 → 13,7
Known bugs
----------
 
* SEVERE: After working with Filter Foundry for a short amount of time (working with sliders, applying, opening again, changing sliders, etc.), the file save dialog (Make dialog) will corrupt the memory!!! You notice it by seeing that icons and folder icons are missing! Later, the program might even crash! (Verified with 1.7.0.12, verified with Visual Studio and OpenWatcom) Application Verifier does not report anything bad.
You can also corrupt the memory by often applying filters and building and doing stuff. And at some point you get the error that preview cannot be shown because memory is out???
Do we have a leak???
Smashing Ctrl+F does NOT cause a leak.
"Deleaker" tool only showed small leaks, nothing very big and no leaks with high hit-count!
* The preview will show the manipulation on the whole rectangle. It does not accurately exclude areas which aren't in a polygon selection area!
 
Minor priority stuff or ideas
-----------------------------
/trunk/ui.c
426,7 → 426,7
// MSDN states: "If the function succeeds, it returns a value greater than 32."
 
TCHAR s[0x300];
xstrcpy(s, (TCHAR*)TEXT("ShellExecuteA failed: "));
xstrcpy(s, (TCHAR*)TEXT("ShellExecute failed: "));
FormatMessage(FORMAT_MESSAGE_FROM_SYSTEM, NULL, GetLastError(), 0, s + xstrlen(s), 0x300 - xstrlen(s), NULL);
dbg(&s[0]);
 
546,13 → 546,29
}
 
Boolean alertuser(TCHAR *err,TCHAR *more){
TCHAR *s = (TCHAR*)malloc((xstrlen(err)+xstrlen(more)+2)*sizeof(TCHAR)), *q;
TCHAR *s = (TCHAR*)malloc((xstrlen(err)+xstrlen(more)+3)*sizeof(TCHAR)), *q; // 3=CR+LF+NUL
Boolean res;
int i;
 
q = xstrcat(s,err);
if (s == NULL) return false;
q = s;
 
for (i = 0; i < xstrlen(err); i++) {
*q++ = err[i];
}
 
#ifdef WIN_ENV
*q++ = CR;
#endif
*q++ = LF;
q = xstrcat(q,more);
*q = 0;
 
for (i = 0; i < xstrlen(more); i++) {
*q++ = more[i];
}
 
*q++ = 0;
 
res = simplealert(s);
free(s);
return res;